Hi @tw-peha

Can you make sure the tests pass?

@toonvd
I've updated the test file with defaults for the new flags. There are no new tests for the new features yet because I don't now the test language enough.

I will wait for a review from a seasoned Magento dev for a merge. I will check and fix test coverage myself later.

Anything new here?

@tw-peha thanks for a great contribution! However, in the current form we decided not to merge this. This is because of the bypass feature. In our original blog post we talked about which basic principles we try to adhere to. One of this is as follows;

Parts of the VCL that take responsibility for configurations that shouldn't be the VCL's responsibility (but the host's or the developer's responsibility) are removed (like configuring passes using URL's)

The bypass functionality in this MR is exactly that and conflicts with this principle. Could you remove that part of the MR?

Ps. a similar discussing is unfolding here mage-os/module-theme-optimization#2 (comment)

In my opinion, the no-store directive within the Cache-Control header could be dropped, to allow for bfcache: magento/magento2#38376